Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CRC32 MPEG-2 #76

Merged
merged 4 commits into from
Jan 18, 2023
Merged

feat: CRC32 MPEG-2 #76

merged 4 commits into from
Jan 18, 2023

Conversation

grabofus
Copy link
Contributor

Add support for CRC32 MPEG-2

@grabofus
Copy link
Contributor Author

Should resolve #65

@alexgorbatchev
Copy link
Owner

Thanks for the PR, I hope to review it sometime next week.

@alexgorbatchev
Copy link
Owner

Some file name issues with missing 2 in mpeg2, but I can fix that. Thanks!

@alexgorbatchev alexgorbatchev merged commit a6bb310 into alexgorbatchev:master Jan 18, 2023
@grabofus
Copy link
Contributor Author

I had some issues with running the unit tests when I had the 2 suffix in mpeg2, although that would've been my preferred way too. Thanks for the merge 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgorbatchev alexgorbatchev alexgorbatchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grabofus @alexgorbatchev