Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with logging fixed. #215

Closed

Conversation

aureateAnatidae
Copy link
Contributor

Removed the timeout string from the logging.info() statement, preventing an exception. Adds previous connection timeout functionality. Fixed previous --timeout argument to use AUTO_DISCONNECT_DELAY as the #of seconds to wait until automatically disconnecting the device and ceasing stream, instead of the connection --timeout argument.

@aureateAnatidae
Copy link
Contributor Author

By the way, the current pull request by Makowski adding the --lsl_time argument has no merge conflicts. Even if it adds a merge conflict for my --timeout argument, I'd rather have his added first. I think it's a lot more important.

@jdpigeon
Copy link
Collaborator

jdpigeon commented Jun 2, 2024

Thanks for turning me on to the issues with timeout while connecting to bands! Also, for pointing out the confusing variety of different timeout constants we had in the project.

I've just cleaned up our timeout code and merged in another feature from @narodnik that adds the ability to define a number of retry attempts when connecting to bands. In my hands, this seems pretty useful for helping ensure connection happens, and with the default of 1 retry, seems to be good enough to get bands connected the majority of the time.

I'm curious whether you think this new retry feature is good enough for your usecase. If so, we probably don't need to expose the timeout variable directly, as for bleak I believe the retries approach is a better way to address flaky connectivity.

@aureateAnatidae
Copy link
Contributor Author

I agree actually, from my limited knowledge of bleak, retries would be better. Timeouts only helped on Debian for some reason (I do not know why at all), and retrying (after clearing the device data/cache) is a lot more consistent of a method on my current setup👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants