Added support for a fallback handler #393
Open
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested changes
Aug 5, 2019
index.js
Outdated
| @@ -413,14 +413,16 @@ alexa.session = function(session) { | |||
|
|
|||
| alexa.router = function(app, request, response, request_json) { | |||
| this.intent = function(intent) { | |||
| request.intent = intent; | |||
There was a problem hiding this comment.
This modifies the incoming request, I don't think that's a good idea, at the very least it's an anti-pattern to be modifying something coming from the outside.
There was a problem hiding this comment.
Hmm, i understand and already updated the code as that field is still accessible from the raw data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought its better to give developers control over the message they want to return when a user's request doesn't match