Skip to content
This repository has been archived by the owner on Feb 3, 2020. It is now read-only.

Settings dialog options to implement #13

Open
aletson opened this issue Jan 9, 2015 · 6 comments
Open

Settings dialog options to implement #13

aletson opened this issue Jan 9, 2015 · 6 comments

Comments

@aletson
Copy link
Owner

aletson commented Jan 9, 2015

Dependent on #5, but I think this deserves a separate issue so that we can more easily track our unimplemented options.

  • sort order
  • group selection (by ID - or by API query to populate?)
  • Field to use for OS detection
  • Polling frequency
  • Sound
@aletson
Copy link
Owner Author

aletson commented Jan 27, 2015

We could set group selections in preferences too - like, expand a group of servers. Something to think about for future release.

@aletson
Copy link
Owner Author

aletson commented Feb 5, 2015

We could use this to support themes.

@aletson aletson added this to the 0.2-release milestone Feb 5, 2015
@eburgueno
Copy link
Collaborator

I would add:

  • Custom refresh interval
  • Enable/disable playing sound

@aletson
Copy link
Owner Author

aletson commented Feb 5, 2015

Sounds good. I'm going to move themes to a different milestone though since they're not nearly as important

@eburgueno
Copy link
Collaborator

Hi Andrew. I know we said in #5 that we would use cookies, but after thinking about it for a while and watching @glasnt presentation at the LCA2015, I got excited about the idea of simply reading our options from the URL. This has a few advantages:

  1. We don't need to worry about cookies storage and their expiration.
  2. URLs are transparent and easy to use.
  3. Each user can still have their own version of the dashboard simply by storing their preferred URL in their Bookmarks.
  4. Zabbix themselves uses this scheme.

The only disadvantage is that we need to validate the options to avoid code injection, but since the Zabbix user with API access that the end-user configures should be read-only, the security of the dashboard doesn't need to be extreme.

I started playing around this idea and just created a new branch so you can have a look at: https://github.com/eburgueno/zabbixweb/tree/feature/optionsFromURL

Of course it needs massive work, but let me know what you think before I continue down the rabbit hole.

@aletson
Copy link
Owner Author

aletson commented Feb 9, 2015

Seems pretty neat. I think we could definitely do something like that. That library you're using looks like it can return a JSON object for URL parsing which I think would make it really easy to extract stuff we need.

aletson pushed a commit that referenced this issue Feb 9, 2016
Moved it down to 5000 for testing, forgot about it. 30 second interval is reasonable but perhaps this should be added to a config menu. Updates #13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants