Refactor ( use html templates, ng annotate, and john papa's guidelines ) #82
Conversation
|
Add support for disabled ( mdp-disabled ) |
|
@corentin-gautier |
|
@alenaksu I just pushed a fix for the min and max date: the field was invalid when the user selected the minDate or the maxDate |
|
Could you add the option to close it when you select the minutes instead of changing the view? and a steper setup for the clock to have it select for example just every 15 minutes because sometimes you click for instance the 20 and it gives back 19 or 21 it's anoying? 😀 |
|
you are the man @corentin-gautier !!! thank you! just one thing, when you put the input in a dialog it close all the dialogs the picker one and the parent one |
|
@flick36 ahah thanks, check out the demo I've just added to the description if you need more infos ;) |
|
@corentin-gautier your demo doesn't work :P it won't change to minutes aso i mention earliear in a dialog it closes the parent dialog :P |
|
@flick36 hum this is working fine for me ...
Regarding the dialog closing: you should not use nested dialogs. This is more of an issue related to how the picker works ( I thing there's already an issue asking for a non-dialog based picker ) |
|
Oh i see, you drag the hours and then it works, but if you click on them it closes, i think it's more natural to click than drag: |
|
@flick36 ok fixed and demo is up to date |
|
@corentin-gautier you are friggin awesome, you should create a bower with yours, and mantain it! Thanks! |
|
it's me again .-., amm when you set the model to the date picker with a valid default date, and the field is required, it will fail the required until you click on the datepicker and select a date, also when the min date it's another model when that models get another date it won't update the min date, and could you implement the doble click to close or the auto close on click in the datepicker 😳 |
|
@flick36 this should be fixed now (it works on the demo, can you confirm it works for you ?) |
|
The min date it's not working, try to put 2 date pickers and in one picker put the min date to the model of the other picker, you'll see it works at first, but if you upadate the other model it won't update, also is there a stepper or min and max for the timepicker? |
|
This is awesome.. Thanks @corentin-gautier @alenaksu |
Hey !
So this is a pretty big refactoring. Feel free to use it or not :) I was trying to reduce the number of scopes in order to boost the perfs but I ended up separating everything in its own file and refactoring the whole thing ^^
There is a very lite performance boost. I will be investigating more in the next few days :)
Codepen demo
DEMO