Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor DND status #2195

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

chemelli74
Copy link
Contributor

Add "dnd" key in the notify service call to honor the DND status:

service: notify.alexa_media_echo_dot_sala
data:
  message: test
  data:
    method: spoken
    type: announce
    dnd: true

If the new key is present and set to true, the message will not be played if the DND switch is active:

2024-02-26 20:06:19.157 INFO (MainThread) [custom_components.alexa_media.media_player] DND active for device Echo Dot Sala, ignoring message

In all other cases it will behave like before.

@chemelli74
Copy link
Contributor Author

This PR will fix #2194

@alandtse
Copy link
Owner

This honestly feels like an Amazon issue and not something we should be patching just for HA.

@chemelli74
Copy link
Contributor Author

Amazon says that DND is honoured only by their notification and not by playing music or messages.
Anyway I think that such enhancement doesn't hurt anyone as the default behaviour is not changed.

@chemelli74
Copy link
Contributor Author

Status update

I did a reset of Echo device a suggested by Alexa Support.
Now when I enable the DND from Alexa app I see a purple flash on the Echo device.
And if I play a message from HA, it's not played 🚀

Only issue is that the DND of Alexa mobile App is not in sync with the DND switch in HA.

Can you please double check if this is the case for you as well ?

@alandtse
Copy link
Owner

alandtse commented Mar 6, 2024

Does this need to be added for other options besides the announcement?

@chemelli74
Copy link
Contributor Author

Does this need to be added for other options besides the announcement?

I think should be honoured for everything but alarms and reminders.

Did you get time to check if HA can be in sync with mobile app DND ?

@alandtse
Copy link
Owner

alandtse commented Mar 6, 2024

No. I mean if you want this feature, I assume you'll do the research.

@alandtse
Copy link
Owner

So do you still want this?

@chemelli74
Copy link
Contributor Author

Sorry a bit busy lately, will update you tomorrow

@chemelli74
Copy link
Contributor Author

Hi @alandtse thx for your patience.

Currently if you enable DND from Alexa Mobile App and then try to play a message from HA, it's not played as DND is honored.
No need to change anything from custom components code.

On the other side, the switch of this great custom components is OFF even if the DND on the Alexa Mobile App is ON.
Viceversa if you enable DND from the custom components HA switch, you find it OFF on Alexa Mobile App.

In the end we have 2 possible approaches:

  • fix the DND switch status to be in sync with Alexa Mobile App ( preferred way)
  • introduce the DND parameter in custom components

Let me know how we can work together to debug the issue and fix it.
Thank you again for your work and time!

@chemelli74
Copy link
Contributor Author

Hi mate, any idea on how to fix the sync between HA and Alexa app ?

@alandtse
Copy link
Owner

alandtse commented Apr 6, 2024

Nope. I'm not actively developing this anymore. Just let me know when this is ready to merge though.

@chemelli74
Copy link
Contributor Author

I'm not actively developing this anymore.

You mean you are not developing this integration any more ?

@alandtse
Copy link
Owner

alandtse commented Apr 6, 2024

Correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants