center zoom around focused point...

[marunjar]

... instead of always keeping top hour while zooming

[entropitor]

Personally, I find that the original zooming gives better results in most of the cases.

Most of the time, the point I'm looking at is more to the top of the screen (somewhere between 1/4 and 1/2 of the screen). So when I zoom out with your changes, The event (and especially it's title) goes off the screen, which seems undesirable to me.

Maybe have a focused point that's a bit higher (and maybe customizable?)

[marunjar]

Customizeable would be the 'easiest' solution.
Is it enough to set it as a fraction app:focusPoint="30%" or do you also want a dimension app:focusPoint="150dp"? The difference would be if you change device orientation.

Current default is then would be 0% or 0dp

[entropitor]

I feel like percentage is probably a better solution.

[marunjar]

done, i used 2 attributes for this

• fixedFocusPointEnabled The focused point (time) while zooming the week view. You can declare it as a fraction app:focusPoint="30%" and if is not declared the top of the view is used.
• fixedFocusPointFraction If you disable the fixed focus point the center of your zoom gesture is used.

[entropitor]

• You seem to have reverted AllDayEventHeight from dimension to int
• The attributes are not totally clear to me yet. Can you make it a bit more clear?
• Why are you adding the WeekViewUtil "prefixes" again?

[marunjar]

What do you mean by 'not totally clear'? Should i rename them or do you need more description and comments?

With fixedFocusPoint i wanted to point out the focused point around we zoom.
You can enable it to have a fixed point, if you disable it zoom is focused around your zoom gesture.

Edit: while reading this i think the name is not the best. how about fixedZoomOriginEnabled and fixedZoomOriginPos? Any other suggestions?

[entropitor]

The description should be more clear. I'm for example confused by fixedFocusPointFraction and focusPoint. And why there is a need for fixedFocusPointEnabled. And why the description for focusPoint seems to be added next to fixedFocusPointEnabled.

I'm guessing you mean:

• focusPoint The focused point (percentage of the vertical screen area) which will be used while zooming the week view. You can declare it as a fraction app:focusPoint="30%". If is not declared the top of the view is used.
• fixedFocusPointEnabled I'm not sure what this is for? Is this the same as not filling in the app:focusPoint? If so, I'd leave it out.
• fixedFocusPointFraction: not sure what this is for.

[marunjar]

you're guessing right.
i changed the property names and description, hope it's a little clearer now.