Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: predicted effect size corrected for unbalanced covariates #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

therealgenna
Copy link

#224

When methylation difference is calculated there are 3 options for effect size calculation: weighted mean, unweighted mean and model prediction (predicted). All of these options calculate or estimate effect size (i.e., methylation difference) which is due both to the group (e.g., treatment vs. control) as well as due to covariates, when they are present/used, and if they are unbalanced (i.e., different) across the treatment groups.

I suggest an additional simple calculation for an average effect size prediction, corrected for covariates (named predicted2 in the new piece of the code). Basically, all covariate sets found in any of the treatment groups will be used in all groups in making model predictions. The rest is the same. In that case the predicted effect will not be due to difference in covariates, will be based on covariate sets used in the data, and will agree with reported statistical significance for group effect. This is also what might be of interest to the user (as a note, it might make sense to return all effect size calculations together, not just one, so that there is no need to rerun the function to get a different version of effect size estimate.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant