Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild if any of the CFLAGS changed #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miniupnp
Copy link

No description provided.

@aklomp
Copy link
Owner

aklomp commented Nov 21, 2019

Thanks for the contribution. Not sure I'm entirely on board with it yet. So this would cause the library to automatically recompile when the compiler flags are changed in the environment? I can see how that would be useful in some specialized scenarios, like when building the library in a multi-target environment, but it seems to me like the outermost build system would need to handle that scenario. The normal workflow here would be to run make clean before recompiling.

Could you please provide a short rationale for this change?

@miniupnp
Copy link
Author

Well it is made so "make clean" is not necessary anymore before building.
It is indeed useless if you always start from a fresh state.

@aklomp
Copy link
Owner

aklomp commented Jun 4, 2022

I intend to close this PR without merging it. I'm still not really on board with the change, as my earlier comment clarifies, and there have also been a lot of changes recently in how this library can be built. In particular, the library can now be built with CMake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants