Improve exception message of ExtractionException #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierallard
force-pushed
the
improve-error-message
branch
from
a1757a0
to
ce26755
Compare
nidup
reviewed
Jun 20, 2017
| @@ -28,8 +28,8 @@ public function parse(\SplFileInfo $file) | |||
|
|
|||
| $content = file_get_contents($file->getRealPath()); | |||
| $tokens = Tokens::fromCode($content); | |||
| $classNamespace = $namespaceExtractor->extract($tokens); | |||
| $className = $classNameExtractor->extract($tokens); | |||
| $classNamespace = $namespaceExtractor->extract($tokens, $file); | |||
There was a problem hiding this comment.
i would catch the ExtractionException here and throw a new ParserException indicating the failing file path.
pierallard
force-pushed
the
improve-error-message
branch
2 times, most recently
from
3eabc88
to
225459c
Compare
nidup
reviewed
Jun 20, 2017
| /** | ||
| * @param \SplFileInfo $file | ||
| * | ||
| * @throws ParseException |
There was a problem hiding this comment.
ParseException or ParsingException ?
nidup
approved these changes
Jun 20, 2017
| /** | ||
| * Class ParseException. | ||
| * | ||
| * @author Pierre Allard <pierre.alalrd@akeneo.com> |
pierallard
force-pushed
the
improve-error-message
branch
4 times, most recently
from
af45442
to
392d04f
Compare
pierallard
force-pushed
the
improve-error-message
branch
from
392d04f
to
ffd1908
Compare
jjanvier
reviewed
Jun 20, 2017
|
To avoid to pass the file in the extractor to throw a more accurate exception :) |
nidup
reviewed
Jun 23, 2017
| $className = $classNameExtractor->extract($tokens); | ||
| try { | ||
| $classNamespace = $namespaceExtractor->extract($tokens, $file); | ||
| $className = $classNameExtractor->extract($tokens, $file); |
There was a problem hiding this comment.
you pass a useless $file param here! (on both lines)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there was an issue on ClassNameExtractor or NamespaceExtractor, the Exception does not link to any file.
This PR improve the exception message to include the errored file.