Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: psr-http version #282

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix: psr-http version #282

wants to merge 3 commits into from

Conversation

tomglvng
Copy link
Collaborator

No description provided.

@tomglvng tomglvng self-assigned this Feb 20, 2024
@tomglvng tomglvng mentioned this pull request Feb 20, 2024
Open
@tomglvng
Copy link
Collaborator Author

tomglvng commented Feb 20, 2024 •
edited

Hello @htuscher,

Tests are broken. Could you fix them, please?

For launching them:

make dependencies
make unit
make spec

Regards,

@tomglvng tomglvng changed the title fix: psr-http version Fix: psr-http version Feb 20, 2024
@htuscher htuscher mentioned this pull request Feb 20, 2024
Open
tomglvng
tomglvng commented Feb 23, 2024
View reviewed changes
src/Client/ClientInterface.php
@@ -11,5 +11,5 @@

interface ClientInterface extends BaseClientInterface
{
public function sendAsyncRequest(RequestInterface $request): PromiseInterface|Promise;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@htuscher Why did you have to do this modification?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the method got renamed in Guzzle 7: https://github.com/guzzle/guzzle/blob/2779e868a00289e1b1fd854af030c43a06f4bcb4/src/ClientInterface.php#L39

AngelinCalu
AngelinCalu approved these changes Mar 8, 2024
View reviewed changes
Copy link

@AngelinCalu AngelinCalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks promising. Our project also uses guzzle7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htuscher htuscher htuscher left review comments

@AngelinCalu AngelinCalu AngelinCalu approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@tomglvng tomglvng

Labels
Contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomglvng @AngelinCalu @htuscher