This repository has been archived by the owner on Sep 8, 2021. It is now read-only.
add "Browse button" for add local cover #1784
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps commons-lang3 from 3.9 to 3.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [liquibase-core](https://github.com/liquibase/liquibase) from 3.8.7 to 3.8.9. - [Release notes](https://github.com/liquibase/liquibase/releases) - [Changelog](https://github.com/liquibase/liquibase/blob/v3.8.9/changelog.txt) - [Commits](liquibase/liquibase@v3.8.7...v3.8.9) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps `tomcat.version` from 8.5.51 to 8.5.54. Updates `tomcat-embed-core` from 8.5.51 to 8.5.54 Updates `tomcat-embed-el` from 8.5.51 to 8.5.54 Updates `tomcat-embed-jasper` from 8.5.51 to 8.5.54 Updates `tomcat-embed-websocket` from 8.5.51 to 8.5.54 Updates `tomcat-annotations-api` from 8.5.51 to 8.5.54 Updates `tomcat-jdbc` from 8.5.51 to 8.5.54 Updates `tomcat-juli` from 8.5.51 to 8.5.54 Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [jetty-jspc-maven-plugin](https://github.com/eclipse/jetty.project) from 9.4.26.v20200117 to 9.4.28.v20200408. - [Release notes](https://github.com/eclipse/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-9.4.26.v20200117...jetty-9.4.28.v20200408) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Previously, transcodes just used default bitrate limits which might either be too low (degrading the quality unnecessarily), or would be too high which wasted bandwidth. Fixes #867 This also now takes VBR sources into account, and gives them a little extra bitrate when transcoding to better reproduce the quality of the source.
My guess is that this probably resolves #624.
The m4a and flac streaming tests no longer result in transcoding (correctly) since a different format is not currently specified by the tests. Adding transcoding tests will be done as a separate PR.
Bumps lucene-core from 8.4.1 to 8.5.1. Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [xmlunit-core](https://github.com/xmlunit/xmlunit) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/xmlunit/xmlunit/releases) - [Changelog](https://github.com/xmlunit/xmlunit/blob/master/RELEASE_NOTES.md) - [Commits](xmlunit/xmlunit@v2.6.3...v2.6.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
The SecurityProperties.ACCESS_OVERRIDE_ORDER constant is no longer available in Spring Boot 2.2. It is replaced with SecurityProperties.BASIC_AUTH_ORDER - 2 in our code.
Spring Security 5 requires[1] storing the encoder id alongside the encoded password
(e.g. "{md5}hash" for an MD5-encoded password hash), which differs from previous
versions.
Airsonic unfortunately stores passwords in plain-text, which is why we are setting
the "no-op" (plain-text) password encoder as a default here. This default will be
used when no encoder id is present.
This means that legacy Airsonic passwords (stored simply as "password" in the db)
will be matched like "{noop}password" and will be recognized successfully. In the
future password encoding updates will be done here.
This fixes the following tests failures:
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 9.656 s <<< FAILURE! - in org.airsonic.player.api.AirsonicRestApiIntTest
[ERROR] pingTest Time elapsed: 0.376 s <<< ERROR!
java.lang.IllegalArgumentException: There is no PasswordEncoder mapped for the id "null"
at org.airsonic.player.api.AirsonicRestApiIntTest.pingTest(AirsonicRestApiIntTest.java:47)
[1] https://spring.io/blog/2017/11/01/spring-security-5-0-0-rc1-released#password-storage-updated
Starting from Spring Boot 2.0, suffix path matching is not enabled by
default anymore[1], so we must enable it manually.
Both setUseSuffixPatternMatch and favorPathExtension calls allow URLs
with extensions to be resolved to the same mapping as without extension.
In Airsonic's case, this is necessary, because a lot of our mappings assume
this behavior (for example "/home.view" URL to a "/home" mapping, or the
entire Subsonic REST API controller).
This fixes crashes when accessing almost all pages (which expect to use
.view URLs), and also fixes the following REST API tests:
[ERROR] Failures:
[ERROR] AirsonicRestApiJukeboxIntTest>AbstractAirsonicRestApiJukeboxIntTest.jukeboxStartActionTest:202->AbstractAirsonicRestApiJukeboxIntTest.performStartAction:282 Status expected:<200> but was:<404>
[ERROR] AirsonicRestApiJukeboxIntTest>AbstractAirsonicRestApiJukeboxIntTest.jukeboxStopActionTest:225->AbstractAirsonicRestApiJukeboxIntTest.performStartAction:282 Status expected:<200> but was:<404>
[ERROR] AirsonicRestApiJukeboxLegacyIntTest.jukeboxStartActionTest:48->AbstractAirsonicRestApiJukeboxIntTest.jukeboxStartActionTest:202->AbstractAirsonicRestApiJukeboxIntTest.performStartAction:282 Status expected:<200> but was:<404>
[ERROR] AirsonicRestApiJukeboxLegacyIntTest.jukeboxStopActionTest:56->AbstractAirsonicRestApiJukeboxIntTest.jukeboxStopActionTest:225->AbstractAirsonicRestApiJukeboxIntTest.performStartAction:282 Status expected:<200> but was:<404>
[1] https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.0-Migration-Guide#spring-mvc-path-matching-default-behavior-change
Bean overriding was deprecated and removed[1] in Spring Boot 2.1, which fails the Jukebox REST API tests that relied on it. This commit replaces it with a new method with the same behavior. [1] https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.1-Release-Notes#bean-overriding
InternetRadioService just ignores the response body and goes to the next URL specified by the Location: header when given a redirect (HTTP 3xx). This caused the mock's getInputStream method to never be called in practice, which was silently ignored before but is now disallowed after upgrading to Spring Boot 2.2.
The `server.context-path` property is replaced by `server.servlet.contextPath` in Spring 5, which needs to be updated in our default service.
We already bundle the equivalent Jakarta modules for Spring Boot 2 dependencies, but two javax modules remain used by Apache CXF.
Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.2.10 to 42.2.12. - [Release notes](https://github.com/pgjdbc/pgjdbc/releases) - [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md) - [Commits](pgjdbc/pgjdbc@REL42.2.10...REL42.2.12) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [java-jwt](https://github.com/auth0/java-jwt) from 3.10.0 to 3.10.2. - [Release notes](https://github.com/auth0/java-jwt/releases) - [Changelog](https://github.com/auth0/java-jwt/blob/master/CHANGELOG.md) - [Commits](auth0/java-jwt@3.10.0...3.10.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [dependency-check-maven](https://github.com/jeremylong/DependencyCheck) from 5.3.0 to 5.3.2. - [Release notes](https://github.com/jeremylong/DependencyCheck/releases) - [Changelog](https://github.com/jeremylong/DependencyCheck/blob/master/RELEASE_NOTES.md) - [Commits](jeremylong/DependencyCheck@v5.3.0...v5.3.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…default. To change the behavior, append 'sql.enforce_size=false' to the default JDBC URL. http://hsqldb.org/doc/guide/dbproperties-chapt.html#N1580D Signed-off-by: Iwao AVE! <harawata@gmail.com>
…configurable via 'sql.nulls_first' property. http://hsqldb.org/doc/guide/dbproperties-chapt.html#N159E5 Signed-off-by: Iwao AVE! <harawata@gmail.com>
…dded with spaces before comparison'. This behavior is configurable via 'sql.pad_space' property. http://hsqldb.org/doc/guide/dbproperties-chapt.html#N15A42 Signed-off-by: Iwao AVE! <harawata@gmail.com>
Signed-off-by: Iwao AVE! <harawata@gmail.com>
…s-is as a column name
Missing null-checks on mediaFileService.getMediaFile() cause NPEs in the Subsonic API and elsewhere, add some checks to avoid these.
…MissingFormatArgumentException: Format specifier '%tm' errors As to why java suddenly started complaining about java.util.MissingFormatArgumentException: Format specifier '%tm' errors I have no idea but the fact is that it did on the 1st of may 2020: ``` Failed to download Podcast from https://example.com/1.mp3 java.util.MissingFormatArgumentException: Format specifier '%tm' ``` Given that the intention of this format string is to produce an ISO date (YYYY-MM-DD) and given that String.format has a special formatter for this which does _not_ produce this error it seems logical to use it.
Avoid useless bookmarks in the list by moving the null-test up so as to avoid generating entries without an associated mediaFile.
Make Travis happy
Automatically upgrade HSQLDB to 2.5.0
Add some null-checks on calls to mediaFileService.getMediaFile()
Bumps jaxb-runtime from 2.3.2 to 2.3.3. Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [jakarta.xml.ws-api](https://github.com/eclipse-ee4j/jax-ws-api) from 2.3.2 to 2.3.3. - [Release notes](https://github.com/eclipse-ee4j/jax-ws-api/releases) - [Commits](jakartaee/jax-ws-api@2.3.2...2.3.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [jakarta.xml.soap-api](https://github.com/eclipse-ee4j/saaj-api) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/eclipse-ee4j/saaj-api/releases) - [Commits](jakartaee/saaj-api@1.4.1...1.4.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Ash Holland <ash@sorrel.sh>
Bumps jakarta.xml.bind-api from 2.3.2 to 2.3.3. Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [maven-assembly-plugin](https://github.com/apache/maven-assembly-plugin) from 3.2.0 to 3.3.0. - [Release notes](https://github.com/apache/maven-assembly-plugin/releases) - [Commits](apache/maven-assembly-plugin@maven-assembly-plugin-3.2.0...maven-assembly-plugin-3.3.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, (sorry for my bad english ! I use translator)
long time Subsonic user, just happily switched to Airsonic :)
I would just like to ask, I think, one useful thing that I have missed for a long time.
I have a nice collection of music and therefore a lot of covers. I take care to name my image files correctly in my folders. some covers are not well recognized, or the back part is displayed instead.
I have to upload the image to the net to make the change.
So would it be possible to add a "browse" button to correct this problem.
thank you
I am using the latest version of Airsonic;)
note : sorry, I must a mistake for this request.