This repository has been archived by the owner on Sep 8, 2021. It is now read-only.
Refactoring IngoreFileTimestamps setting and bring it to the UI #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is refactoring (actually renaming the property) from #607. It also brings this setting to the UI.
As it doesn't make any sense to me, to enable the full scan all the time, this setting is reseting itself after every scan. If we wouldn't do it like this I'm pretty sure, that some user might accidentaly turn it on all the time and experience poor scan performance.
Related issues:
#649
#711
#732
#359
#797
Bringing this setting to the UI is also needed as preparation for a comming PR about an option to select the cover art source.