Update class-acf-to-rest-api-acf-api.php

[jacktator]

Applied Fix from #141
Fixed #241 #129

[airesvsg]

Hello @jacktator,
Thanks for your time and your PR.
I'll test and merge if all right.
Thanks

[airesvsg]

This condition never will match because of it:
https://github.com/airesvsg/acf-to-rest-api/pull/247/files#diff-2b1f470cce5f57d891c442678d8a5f6fR64

[airesvsg]

why dot and comma?

[evvvritt]

Hi @airesvsg and @jacktator, thanks for working on this. Much appreciated if this could be merged so updating Users works fluidly. (@jacktator - perhaps you didn't see @airesvsg's comments?) Thanks

[jacktator]

@airesvsg Hi. Sorry for the super late reply.

As suggested in original comment, I merely applied the fix suggested by @ghost .

I'm not sure how or why it worked, but it did.

I just bumped into the same issue again in another project, and applied this fix again, and it's still working.

So it would be much appreciated if you could have a look at the original issues and the fix suggested. Thank you.

[qduborper]

Hi, this fix doesn't work anymore for me using latest version for ACF Pro (5.7). It seems that the acf_get_field_groups function require one more filter parameter user_form in order the request work. So now by replacing

$filter = array('user_id' => str_replace( 'user_', '', $id ) );

with

$filter = array(
    'user_id' => str_replace( 'user_', '', $id ),
    'user_form' => 'edit' 
);

line of 136 of your pull request v3/lib/class-acf-to-rest-api-acf-api.php the update user feature works again. @jacktator can you update your merge request including this change ?

Best regards

[Twansparant]

This fix works for me, will this get merged someday?

Also this line:

if(is_string($this->id))

should become:

if ( is_string( $this->id) && $this->id !== 'options')

[JoshuaVB]

Hi, this fix doesn't work anymore for me using latest version for ACF Pro (5.7). It seems that the acf_get_field_groups function require one more filter parameter user_form in order the request work. So now by replacing

$filter = array('user_id' => str_replace( 'user_', '', $id ) );

with

$filter = array(
    'user_id' => str_replace( 'user_', '', $id ),
    'user_form' => 'edit' 
);

line of 136 of your pull request v3/lib/class-acf-to-rest-api-acf-api.php the update user feature works again. @jacktator can you update your merge request including this change ?

Best regards

Oh my goodness, what a godsend! I applied @ghost's update and it wasn't working (even though all of the old Issues state that it will).

@qduborper update was EXACTLY what was necessary - I cannot thank you enough.

@airesvsg Please please please merge this PR, without it the plugin is completely ineffective at updating User ACF data.

[edouardflowasia]

Thank you for the fix. This was driving me crazy. Is there any plan to add this fix to next updates ?