Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Prestashop: Make Builder Compatible #38123

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

topefolorunso
Copy link
Collaborator

@topefolorunso topefolorunso commented May 10, 2024

What

Made Source Prestashop compatible with the builder

How

  • Import spec file to manifest
  • Update CDK version

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 10:27pm

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! ✅ pending setting the right date in the changelog

@@ -104,6 +104,7 @@ If there are more endpoints you'd like Airbyte to support, please [create an iss

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :-------------------------------------------------------- | :------------------------------------------------------------------------------ |
| 1.0.5 | 2024-05-19 | [38123](https://github.com/airbytehq/airbyte/pull/38123) | Made Compatible with Builder |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| 1.0.5 | 2024-05-19 | [38123](https://github.com/airbytehq/airbyte/pull/38123) | Made Compatible with Builder |
| 1.0.5 | 2024-05-13 | [38123](https://github.com/airbytehq/airbyte/pull/38123) | Made Compatible with Builder |

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@topefolorunso can you also run the formatter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/prestashop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants