Strosek/test conn err retry #38084
Draft
Strosek/test conn err retry #38084
+417
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…migrate-product-images-variants-to-bulk
…migrate-product-images-variants-to-bulk
…migrate-product-images-variants-to-bulk
…migrate-product-images-variants-to-bulk
…migrate-product-images-variants-to-bulk
…migrate-product-images-variants-to-bulk
… for the product_images
…migrate-product-images-variants-to-bulk
…migrate-product-images-variants-to-bulk
…migrate-product-images-variants-to-bulk
…migrate-product-images-variants-to-bulk
…migrate-product-images-variants-to-bulk
…ct-images-variants-to-bulk' into strosek/test-conn-err-retry
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
maxi297
changed the base branch from
master
to
baz/source/shopify/migrate-product-images-variants-to-bulk
Base automatically changed from
baz/source/shopify/migrate-product-images-variants-to-bulk
to
master
May 14, 2024 09:50
octavia-squidington-iii
removed
the
area/documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add tests for reading records from a GraphQL bulk in Shopify
How
Created an integration tests file for testing the entrypoint
read()function. A couple tests were added, one with a successful mock and one with an ConnectionError raised when the mocker tries to build a response.Review guide
User Impact
None directly, just for general quality improvement.
Can this PR be safely reverted and rolled back?