Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controller.start() is missing type annotation #386

Closed
cuu508 opened this issue Oct 26, 2023 · 0 comments · Fixed by #420
Closed

Controller.start() is missing type annotation #386

cuu508 opened this issue Oct 26, 2023 · 0 comments · Fixed by #420

Comments

@cuu508
Copy link
Contributor

cuu508 commented Oct 26, 2023

The aiosmtpd library has the py.typed marker (awesome!), but the aiosmtpd.controller.Controller.start() method has no type annotation for the return type. This leads to a mypy warning in calling code (when run with --strict):

path/to/file.py:141: error: Call to untyped function "start" in typed context  [no-untyped-call]

Looking at the source, seems it could be annotated to return None.
cuu508 added a commit to cuu508/aiosmtpd that referenced this issue Mar 5, 2024
@cuu508
Add type annotation for Controller.start()
ff7b84e 
Fixes: aio-libs#386
@cuu508 cuu508 mentioned this issue Mar 5, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add type annotation for Controller.start() cuu508/aiosmtpd
1 participant
@cuu508