Update type annotations in pool.py #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jettify
reviewed
May 3, 2023
jettify
approved these changes
May 4, 2023
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 86.88% 86.93% +0.05%
==========================================
Files 6 6
Lines 488 490 +2
Branches 73 73
==========================================
+ Hits 424 426 +2
Misses 48 48
Partials 16 16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Since the annotation represents the elements of the `kwargs` mapping rather than the mapping itself, `Any` is a more appropriate annotation for `kwargs`.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
dsnkwarg tocreate_pool(),_create_pool(), and Pool's__init__method1Are there changes in behavior for the user?
Users will notice that
dsnis now a required keyword argument forcreate_pool()and Pool's__init__method. It was previously a required kwarg for normal operability with pooling but was not defined as such on either of the aforementioned callables.Related issue number
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.Footnotes
https://github.com/aio-libs/aioodbc/pull/431#discussion_r1184518065 ↩
https://peps.python.org/pep-0563/ ↩