Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More typing for connection. #420

Merged
merged 1 commit into from
Apr 20, 2023
Merged

More typing for connection. #420

merged 1 commit into from
Apr 20, 2023

Conversation

jettify
Copy link
Member

@jettify jettify commented Apr 19, 2023

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #420 (9630f77) into master (5f81278) will decrease coverage by 0.10%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
- Coverage   86.98%   86.88%   -0.10%     
==========================================
  Files           6        6              
  Lines         484      488       +4     
  Branches       73       73              
==========================================
+ Hits          421      424       +3     
- Misses         47       48       +1     
  Partials       16       16              
Impacted Files Coverage Δ
aioodbc/connection.py 85.21% <94.73%> (-0.30%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jettify jettify merged commit 1289cc6 into master Apr 20, 2023
5 of 6 checks passed
@jettify jettify deleted the more-typing branch April 20, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant