Fix test_utils.make_mocked_request behaviour for empty payload
#7168
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
| @@ -632,7 +633,7 @@ def make_mocked_request( | |||
| protocol.writer = writer | |||
|
|
|||
| if payload is sentinel: | |||
| payload = mock.Mock() | |||
| payload = EMPTY_PAYLOAD | |||
There was a problem hiding this comment.
Feels to me like everything here should be a mock. Maybe instead we should autospec it? That should ensure it gets an appropriate mock with the correct methods.
Suggested change
| payload = EMPTY_PAYLOAD | |
| payload = create_autospec(StreamResponse, spec_set=True, instance=True) |
There was a problem hiding this comment.
Same should really be done to all the rest of this code... Would make the code safer and more maintainable.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7168 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 106 106
Lines 31093 31098 +5
Branches 3875 3875
=======================================
+ Hits 30278 30283 +5
Misses 613 613
Partials 202 202
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
webknjaz
added
backport-3.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes #7167
In case of empty payload when initialized, it now assigns the payload as
EMPTY_RESPONSEinstance ofEmptyStreamReaderavailable via aiohttp/streams.pyAre there changes in behavior for the user?
No
Related issue number
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.