Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix middleware registration for sanic 22.12.0+ #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Zerogoki00
Copy link

#92

@semmypurewal
Copy link

Thanks for contributing this. It helped me solve my problem.

Out of curiosity, why did you choose to do this rather than just uncommenting the @app.middleware("request") and @app.middleware("response") lines? I made that change on my end and it also seems to work. Any particular reason to use the explicit register_middleware API?

@ahopkins
Copy link
Owner

Wow, I am super late at reviewing this. Sorry about that. We probably should update this to give it a high priority (if in the relevant Sanic version).

@Zerogoki00
Copy link
Author

Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants