This repository has been archived by the owner on Oct 10, 2022. It is now read-only.
馃悰 FIX: Move block JS to footer #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to the Code-Docs: |
|
@riyuk I will look into it. |
salcode
force-pushed
the
sf/js-ver-number-65
branch
2 times, most recently
from
874fb4e
to
c74b60a
Compare
Add a version number parameter (null), which allows the following parameter (`true`) to be properly interpreted as the `in_footer` parameter. props to @riyuk for pointing out `null` is the appropriate value, rather than empty string ("") See ahmadawais#65
salcode
force-pushed
the
sf/js-ver-number-65
branch
from
c74b60a
to
708df56
Compare
|
+1 on Good catch @riyuk 馃憤 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a version number parameter (an empty string), which allows the
following parameter (
true) to be properly interpreted as thein_footerparameter.See #65
I'm having trouble using the modified template to generate the new block but I'm certain that is a separate problem in how I'm running my update (see #67). However, if it is easier to reject this PR and make the change yourself, that is no problem.