-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PG protocol handling on big-endian #379
base: master
Are you sure you want to change the base?
Conversation
Added missing |
MacOS is failing with this pull request |
Maybe https://stackoverflow.com/questions/20813028/endian-h-not-found-on-mac-osx |
I was googling around and found like half a dozen different answers. Will give this one a shot now. |
Keep an eye on the CI environment |
d21824a
to
b01631a
Compare
Its |
Replace the homegrown swap-bytes machinery by system functions that work correctly independently from the host byte order. pgagroal_read/write_* were wrong on big-endian machines before.
Should it be a "wrapper" include, or an |
Sorry the commit where I had tried |
@df7cb Any updates ? |
I believe my patch is correct, but MacOS lacks the modern |
@df7cb Maybe we should merge this on Likely the issue is the same with pgmoneta and pgexporter... |
Thinking about it some more - we should leave the existing functionality for Could you rework your patch for that ? |
Replace the homegrown swap-bytes machinery by system functions that work correctly independently from the host byte order. pgagroal_read/write_* were wrong on big-endian machines before.
Problem noticed on Debian s390x where connects to pgagroal were just hanging indefinitely.