fix plot_2d color fill #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-reinhard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest for python versions 3.8, 3.9 3.10 are failing, fixes for this are in #193
This PR addresses issue #182
For curves with negative values the
plot_2d(plot_curve=True)was not coming up correctly because the extent of thenimshowran from 0 to max(curve_data). Now the extent is:extent = [min(curve_data) or 0, max(curve_data) or default, curve.stop, curve.start]This allows for complete color fill of the curve.
Also enabled axis tick labels when plotting the curve because it has a dimension, unlike the
plot_curve=Falseplot.Previous output before changes:
Output with these changes: