Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot_2d is broken #182

Open
kwinkunks opened this issue Jan 6, 2022 · 5 comments · Fixed by #187
Open

plot_2d is broken #182

kwinkunks opened this issue Jan 6, 2022 · 5 comments · Fixed by #187
Labels

Comments

@kwinkunks
Copy link
Member

image

@kwinkunks kwinkunks added the bug label Jan 6, 2022
@patrick-reinhard
Copy link
Collaborator

Could you share the reproduction steps of this bug, which file is this? What is the expected output?

If I run tests/test_curve_2d_plot() I get:

image

And if I load P-129_out.LAS, select 'GR' and run:

curve.plot_2d(cmap='viridis', curve=True, lw=0.3, edgecolor='k')

I get:

image

@kwinkunks
Copy link
Member Author

Hm, good point -- and I didn't notice that I was plotting (200 - gr) there. Still, seems like the second plot here should produce something:

w = Well.from_las('data/P-129_out.LAS')
gr = w.data['GR']

# This works:
gr.plot_2d(cmap='viridis', curve=True, lw=0.3, edgecolor='k')

# This doesn't:
(200 - gr).plot_2d(cmap='viridis', curve=True, lw=0.3, edgecolor='k')

@patrick-reinhard
Copy link
Collaborator

This also happens in 0.4.10, it has to do with the position when clipping the imshow :

image.

The extend of the imshow needs to be from min(curve_data) up to max(curve_data) when plot_curve = True. I've created a PR with a fix.

@patrick-reinhard patrick-reinhard linked a pull request Jan 11, 2022 that will close this issue
@ThomasMGeo
Copy link
Contributor

welly_2d_lineplot

Getting some other funny plot2d issues, this is version 4.10

@patrick-reinhard
Copy link
Collaborator

@ThomasMGeo could you share a the reproduction steps that lead you to this error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants