Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iframe view #217

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Iframe view #217

wants to merge 1 commit into from

Conversation

Rudloff
Copy link
Contributor

@Rudloff Rudloff commented Aug 8, 2017

Now that #212 is merged, we integrate Agendav into one of our web apps.
But we needed a way to display a simplified version into an iframe.
So this PR adds a new /iframe route that only shows the calendar (no header or sidebar).

(Note that I add to include a hidden calendar_list element since it is used by the JS to store the calendar states.)

@jorgelzpz jorgelzpz assigned jorgelzpz and unassigned jorgelzpz Aug 22, 2017
@jorgelzpz
Copy link
Collaborator

@Rudloff sorry for not answering before!

This seems like a great idea, but I'm slightly worried about HTTP headers required to make this safe/secure.

I'm not an expert on that subject, do you have any experience on that?

@Rudloff
Copy link
Contributor Author

Rudloff commented Aug 22, 2017

Are you talking about things like the X-Frame-Options header?
I think it's kind of hard to predict if the user will need to embed the iframe on another domain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants