[BUGFIX] Add check to ensure that setTimeout
is not called with a value greater than MAX_SIGNED_INTEGER
#1391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In my local dev environment I've occasionally run into a scenario where my console gets flooded with
TimeoutOverflowWarning
s. I eventually traced the problem back to agenda'sprocessJobs
logic which would set the timeout for re-processing a future job without checking the bounds of the timeout value.Investigation
Unfortunately for us, the
setTimeout
method interprets values greather than2e31-1
as a negative value, which is in turn interpreted as1ms
, causing a tight loop which will continue until the differen between "now" andnextRunAt
is less than MAX_SIGNED_INTEGER.Changes
runIn
interval calculation by adding aMath.min
computation against MAX_SIGNED_INTEGER (2e31-1
)Keywords: TimeoutOverflowWarning