notes on thd_niftiread.c #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afniHQ
commented
Dec 13, 2021
mrneont
reviewed
Feb 1, 2022
src/thd_initdblk.c
Outdated
Comment on lines
1146
to
1149
| float fracdiff; | ||
|
|
||
| fracdiff = frac_diff(atr_flt->fl[0], | ||
| dset->daxes->ijk_to_dicom_real.m[0][0]); |
There was a problem hiding this comment.
I don't think the float var here should have the same name as the function---it makes my head hurt. (Perhaps it should make the compiler's head hurt, too.)
mrneont
reviewed
Feb 1, 2022
src/thd_initdblk.c
Outdated
Comment on lines
730
to
736
| float fracdiff; | ||
|
|
||
| if (fabs(old) + fabs(new) != 0) { | ||
| fracdiff = fabs(old - new) / (fabs(old) + fabs(new)); | ||
| } else { | ||
| fracdiff = 0; | ||
| } |
There was a problem hiding this comment.
How about perhaps:
float fracdiff, denom;
denom = fabs(old) + fabs(new);
if (denom) {
fracdiff = 2 * fabs(old - new) / denom;
} else {
fracdiff = 0.;
}
... which calculates the denominator only once? A factor of 2 in the numerator makes sense to me, from the point of view of considering the denominator to be the average of old and new.
afni-rickr
reviewed
Feb 2, 2022
src/thd_initdblk.c
Outdated
| int label_c = 0, count_o = 0, count_i = 0; | ||
|
|
||
| if (validate) { /* disco change */ | ||
| // should I free these vaiables at the end of the if statement? |
There was a problem hiding this comment.
A free is only needed when using a corresponding malloc/calloc/realloc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for testing things out: to go into ni_attr branch