Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CI test data to repo hosted on GIN #268

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

YurBoiRene
Copy link
Contributor

Changes the CI test data repository leej3/afni_ci_test_data hosted at gin.g-node.org. The repository on GIN does not require access to NIH or afni servers which makes it easier and more accessible to update test data. in the future.

Additionally, this repository is already updated with 3dClusterize data to fix the currently failing tests (Issue #266).

@YurBoiRene YurBoiRene marked this pull request as draft May 9, 2021 04:16
A quirk of GIN I assume. afni_ci_test_data.git/config does not exist but
afni_ci_test_data/config does.
@YurBoiRene YurBoiRene marked this pull request as ready for review May 9, 2021 16:42
this reverts previous breakage of coverage functionality.
coverage functionality is now turned off for all circleci jobs
@leej3
Copy link
Collaborator

leej3 commented May 9, 2021

Looks good to me.

@afni-rickr I reverted your changes (they caused a test to fail) and turned off coverage in the circleci file... so coverage testing won't happen anymore but the functionality is left intact. Let me know if that's not ok.

@mrneont could you confirm that the data is as you suspect/expect given your changes:
https://gin.g-node.org/leej3/afni_ci_test_data/src/master/sample_test_output/ptaylor/test_3dClusterize_new

@leej3 leej3 mentioned this pull request Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants