-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add __str__() methods to EventDataFrame and GazeDataFrame #727
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 60 60
Lines 2813 2823 +10
Branches 714 715 +1
=========================================
+ Hits 2813 2823 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that a lot of print()
statements are being used. this is because the python interpreter uses the __repr__()
method right?
can you additionally implement a __repr__()
method for both classes and that just forward to the __str__()
method?
like this:
def __repr__(self): -> str:
return self.__str__()
then you should be able to remove all the print statements in the notebooks and examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I just did some minor reformattings in the notebokos.
Now its's ready to merge, thanks a lot for your work!
Description
Added string representations to EventDataFrame and GazeDataFrame
Fixes issue # 448
Implemented changes
Insert a description of the changes implemented in the pull request.
EventDataFrame.__str__()
method which includes frame in outputGazeDataFrame.__str__()
method which includes experiment and frame in outputType of change
Checklist: