Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parse eyelink mount config and pupil data type #725

Merged
merged 27 commits into from
May 17, 2024

Conversation

theDebbister
Copy link
Member

@theDebbister theDebbister commented Apr 26, 2024

Description

Please include a clear and concise description of the change and which issue is fixed.
Please also include excepted improvements, relevant motivation and context.
List any dependencies that are required for this change.

Fixes issue #510

Implemented changes

Insert a description of the changes implemented in the pull request.

  • added parsing of mount configuration
  • added parsing of pupil data type
  • more tests for data loss ratio calculation

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change is or requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (89ff50f) to head (3dc52b1).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #725   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           60        60           
  Lines         2806      2813    +7     
  Branches       712       714    +2     
=========================================
+ Hits          2806      2813    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theDebbister theDebbister marked this pull request as ready for review April 26, 2024 11:56
@theDebbister theDebbister changed the title Feature/parse eyelink metadata feat: parse eyelink mount config and pupil data type Apr 26, 2024
@github-actions github-actions bot added the enhancement New feature or request label May 17, 2024
@dkrako dkrako enabled auto-merge (squash) May 17, 2024 08:44
Copy link
Contributor

@dkrako dkrako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot for!

I just changed two small details in the code:

  • shorten head_stabilization field from remote (target sticker)to just remote
  • cast onset, offset and duration of blinks to integers

@dkrako dkrako merged commit 6123062 into main May 17, 2024
21 checks passed
@dkrako dkrako deleted the feature/parse-eyelink-metadata branch May 17, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants