-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parse eyelink mount config and pupil data type #725
Conversation
# Conflicts: # src/pymovements/utils/parsing.py # tests/unit/utils/parsing_test.py
# Conflicts: # src/pymovements/utils/parsing.py # tests/unit/utils/parsing_test.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 60 60
Lines 2806 2813 +7
Branches 712 714 +2
=========================================
+ Hits 2806 2813 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks a lot for!
I just changed two small details in the code:
- shorten
head_stabilization
field fromremote (target sticker)
to justremote
- cast onset, offset and duration of blinks to integers
Description
Please include a clear and concise description of the change and which issue is fixed.
Please also include excepted improvements, relevant motivation and context.
List any dependencies that are required for this change.
Fixes issue #510
Implemented changes
Insert a description of the changes implemented in the pull request.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
Checklist: