-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Google Maps API key in requests #6
base: master
Are you sure you want to change the base?
Conversation
@@ -7,9 +7,10 @@ | |||
from urllib.parse import quote_plus | |||
from pytz import timezone | |||
from tzwhere import tzwhere | |||
from django.conf.settings import GOOGLE_MAPS_API_KEY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tying this to Django isn't a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this is supposed to be a simple library which isn't tied to django. Let's make this part of the signature?
@@ -7,9 +7,10 @@ | |||
from urllib.parse import quote_plus | |||
from pytz import timezone | |||
from tzwhere import tzwhere | |||
from django.conf.settings import GOOGLE_MAPS_API_KEY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this is supposed to be a simple library which isn't tied to django. Let's make this part of the signature?
No description provided.