[Client-1432] creates minimum connections on client startup #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaf
requested changes
Jun 5, 2023
lib/aerospike/cluster.rb
Outdated
| @@ -63,6 +58,13 @@ def initialize(policy, hosts) | |||
| end | |||
|
|
|||
| initialize_tls_host_names(hosts) if tls_enabled? | |||
|
|
|||
| @min_connections_per_node = policy.min_connections_per_node | |||
There was a problem hiding this comment.
This information is already in the client_policy. No need to define new class variables to hold it.
lib/aerospike/cluster.rb
Outdated
| @max_connections_per_node = policy.max_connections_per_node | ||
|
|
||
| if @min_connections_per_node > @max_connections_per_node | ||
| raise Aerospike::Exceptions::Aerospike.new(Aerospike::ResultCode::PARAMETER_ERROR, "Invalid connection range") |
There was a problem hiding this comment.
A more descriptive error message would be more helpful.
lib/aerospike/cluster.rb
Outdated
| @@ -584,7 +586,9 @@ def remove_alias(aliass) | |||
| end | |||
|
|
|||
| def create_node(nv) | |||
| ::Aerospike::Node.new(self, nv) | |||
| node = ::Aerospike::Node.new(self, nv) | |||
| node.create_min_connections | |||
There was a problem hiding this comment.
You can pass the number to the method. That would remove the need to open the cluster class variables to the node. It would also make that method more flexible.
lib/aerospike/node.rb
Outdated
| @@ -55,6 +55,7 @@ def initialize(cluster, nv) | |||
| @replica_index = Atomic.new(0) | |||
| @racks = Atomic.new(nil) | |||
|
|
|||
| @min_connections = cluster.min_connections_per_node | |||
There was a problem hiding this comment.
This is unnecessary. See prior comment.
lib/aerospike/node.rb
Outdated
| @@ -69,6 +70,17 @@ def has_rack(ns, rack_id) | |||
| racks[ns] == rack_id | |||
| end | |||
|
|
|||
| def create_min_connections | |||
| current_number_of_connections = @connections.length | |||
| if @min_connections > 0 | |||
There was a problem hiding this comment.
Directly use cluster.client_policy.min_connections.
| @@ -18,7 +18,7 @@ module Aerospike | |||
|
|
|||
| class Pool #:nodoc: | |||
|
|
|||
| attr_accessor :create_proc, :cleanup_proc, :check_proc | |||
| attr_accessor :create_proc, :cleanup_proc, :check_proc, :max_size | |||
There was a problem hiding this comment.
Where is this value initialized?
khaf
requested changes
Jun 16, 2023
khaf
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.