Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS-234] CI/CD: Build manylinux wheels and upload them to JFrog on every push to an arbitrary branch #606

Merged
merged 12 commits into from
May 21, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Apr 24, 2024

Extra changes: When status checks for a workflow are shown due to a push or pull_request event, it will also show status checks for any reusable workflow in it. Only show status check for build-wheels.yml if it's not triggered by a pull request or push event. This prevents status checks for the same build-wheels.yml run from showing twice--one from the workflow that called build-wheels.yml, and another from the build-wheels.yml workflow itself

build-wheels.yml will build wheels on all platforms, but we can optimize this later to only build the manylinux artifacts so we don't waste resources to build the other wheels we don't need

No regression for upload-to-jfrog.yml: https://github.com/aerospike/aerospike-client-python/actions/runs/9177026728

  • Used dev-test branch and a test JFrog repo to check that artifacts are still uploaded to the JFrog PyPI repo properly
  • Deleted the tag that was generated from this test run

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.35%. Comparing base (17335dc) to head (159a8c2).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #606   +/-   ##
=======================================
  Coverage   81.35%   81.35%           
=======================================
  Files         100      100           
  Lines       15358    15358           
=======================================
  Hits        12494    12494           
  Misses       2864     2864           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 changed the title [CLIENT-1837] CI/CD: Build manylinux wheels on every push to a branch [CLIENT-1837] CI/CD: Build manylinux wheels on every push to a branch and upload to JFrog Apr 30, 2024
@juliannguyen4 juliannguyen4 changed the title [CLIENT-1837] CI/CD: Build manylinux wheels on every push to a branch and upload to JFrog [DEVOPS-234] CI/CD: Build manylinux wheels and upload them to JFrog on every push to an arbitrary branch May 7, 2024
@juliannguyen4 juliannguyen4 marked this pull request as ready for review May 21, 2024 15:37
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@juliannguyen4 juliannguyen4 merged commit ac4f4c4 into dev May 21, 2024
138 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-1837-cicd-dl-gh-builds branch May 21, 2024 18:10
DomPeliniAerospike added a commit that referenced this pull request May 22, 2024
* [CLIENT-1837] CI/CD: Label version with git commit when building on a non-tagged commit (#605)

* Also label version when building unoptimized, with macOS debug support, or with uncommitted changes to the repo (i.e add a "dirty" label)
* Rename config.conf to config.conf.template and add config.conf to .gitignore, so creating and modifying config.conf won't cause the repo to be in a dirty state

* Auto-bump version to 15.0.1rc3.dev1 [skip ci]

* [DEVOPS-234] CI/CD: Build manylinux wheels and upload them to JFrog on every push to an arbitrary branch (#606)

* CI/CD: Add option to build and upload unoptimized wheels to JFrog for QE

* Auto-bump version to 15.0.1rc3.dev2 [skip ci]

---------

Co-authored-by: juliannguyen4 <109386615+juliannguyen4@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants