Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-2539] Fix potential crashes if C client receives invalid string data from the server #588

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

juliannguyen4
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 39.28571% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 81.19%. Comparing base (17335dc) to head (677edd0).
Report is 1 commits behind head on dev.

Files Patch % Lines
src/main/conversions.c 43.33% 17 Missing ⚠️
src/main/client/set_xdr_filter.c 0.00% 4 Missing ⚠️
src/main/serializer.c 20.00% 4 Missing ⚠️
src/main/client/info_random_node.c 25.00% 3 Missing ⚠️
src/main/client/info_single_node.c 25.00% 3 Missing ⚠️
src/main/client/get_cdtctx_base64.c 66.66% 1 Missing ⚠️
src/main/client/get_expression_base64.c 66.66% 1 Missing ⚠️
src/main/geospatial/type.c 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #588      +/-   ##
==========================================
- Coverage   81.35%   81.19%   -0.16%     
==========================================
  Files         100      100              
  Lines       15358    15414      +56     
==========================================
+ Hits        12494    12516      +22     
- Misses       2864     2898      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 changed the title [CLIENT-2539] Fix GeoJSON string crash [CLIENT-2539] Fix potential crashes if C client receives invalid string data from the server Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants