CLIENT-2476 - Disallow use of add-ops in foreground scans/queries #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLIENT-2476 Disallowed use of operations with foreground queries (foreach and results) Added sufficent testing for each error condition
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #552 +/- ##
==========================================
+ Coverage 81.25% 81.29% +0.04%
==========================================
Files 99 99
Lines 14897 14913 +16
==========================================
+ Hits 12105 12124 +19
+ Misses 2792 2789 -3 ☔ View full report in Codecov by Sentry. |
juliannguyen4
requested changes
Jan 9, 2024
juliannguyen4
requested changes
Jan 10, 2024
Disallowed use of ops with scan.results and scan.foreach Replaced test cases with the corect test cases. Fixed lint issuess
juliannguyen4
requested changes
Jan 10, 2024
|
You should also specify in the documentation for query.add_ops() that it should not be used for foreground queries (i.e when calling |
Co-authored-by: juliannguyen4 <109386615+juliannguyen4@users.noreply.github.com>
Co-authored-by: juliannguyen4 <109386615+juliannguyen4@users.noreply.github.com>
Co-authored-by: juliannguyen4 <109386615+juliannguyen4@users.noreply.github.com>
I will add documentation to explain this and let you know when it has been finished. |
Co-authored-by: juliannguyen4 <109386615+juliannguyen4@users.noreply.github.com>
DomPeliniAerospike
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLIENT-2476
Disallowed use of operations with foreground queries (foreach and results) Added sufficent testing for each error condition