-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLIENT-681] Dynamically grow array of objects to serialize #548
Open
DomPeliniAerospike
wants to merge
14
commits into
dev
Choose a base branch
from
CLIENT-681
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLIENT-681 Replaced static_pool with dynamic_pool Change as_bytes from heap to stack for operations and expressions.
CLIENT-681 Added an expanding block size and pointer block to avoid several realloc calls
juliannguyen4
changed the title
CLIENT-681
[CLIENT-681] Dynamically grow array of objects to serialize
Jan 4, 2024
Change Dynamic_pool_resize, dynamic_pool_init, and pool_destroy to inline functions rather than macros Ran linter and fixed flake issues Renamed dynamic_pool.h to dynamic_pool.hpp to solve precommit issues
To fix clang-format issues
CLIENT-681 Replaced static_pool with dynamic_pool Change as_bytes from heap to stack for operations and expressions.
CLIENT-681 Added an expanding block size and pointer block to avoid several realloc calls
Change Dynamic_pool_resize, dynamic_pool_init, and pool_destroy to inline functions rather than macros Ran linter and fixed flake issues Renamed dynamic_pool.h to dynamic_pool.hpp to solve precommit issues
To fix clang-format issues
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #548 +/- ##
==========================================
- Coverage 81.35% 81.33% -0.02%
==========================================
Files 100 100
Lines 15356 15395 +39
==========================================
+ Hits 12493 12522 +29
- Misses 2863 2873 +10 ☔ View full report in Codecov by Sentry. |
changed pool_destroy to true for querys and scans
* [CLIENT-1837] CI/CD: Label version with git commit when building on a non-tagged commit (#605) * Also label version when building unoptimized, with macOS debug support, or with uncommitted changes to the repo (i.e add a "dirty" label) * Rename config.conf to config.conf.template and add config.conf to .gitignore, so creating and modifying config.conf won't cause the repo to be in a dirty state * Auto-bump version to 15.0.1rc3.dev1 [skip ci] * [DEVOPS-234] CI/CD: Build manylinux wheels and upload them to JFrog on every push to an arbitrary branch (#606) * CI/CD: Add option to build and upload unoptimized wheels to JFrog for QE * Auto-bump version to 15.0.1rc3.dev2 [skip ci] --------- Co-authored-by: juliannguyen4 <109386615+juliannguyen4@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.