Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-681] Dynamically grow array of objects to serialize #548

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

DomPeliniAerospike
Copy link
Collaborator

@DomPeliniAerospike DomPeliniAerospike commented Jan 4, 2024

No description provided.

CLIENT-681
Replaced static_pool with dynamic_pool
Change as_bytes from heap to stack for operations and expressions.
CLIENT-681
Added an expanding block size and pointer block to avoid several realloc calls
@juliannguyen4 juliannguyen4 changed the title CLIENT-681 [CLIENT-681] Dynamically grow array of objects to serialize Jan 4, 2024
Change Dynamic_pool_resize, dynamic_pool_init, and pool_destroy to inline functions rather than macros
Ran linter and fixed flake issues
Renamed dynamic_pool.h to dynamic_pool.hpp to solve precommit issues
To fix clang-format issues
CLIENT-681
Replaced static_pool with dynamic_pool
Change as_bytes from heap to stack for operations and expressions.
CLIENT-681
Added an expanding block size and pointer block to avoid several realloc calls
Change Dynamic_pool_resize, dynamic_pool_init, and pool_destroy to inline functions rather than macros
Ran linter and fixed flake issues
Renamed dynamic_pool.h to dynamic_pool.hpp to solve precommit issues
To fix clang-format issues
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

Attention: Patch coverage is 92.69231% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 81.33%. Comparing base (c5438a5) to head (1446ac5).
Report is 4 commits behind head on dev.

Files Patch % Lines
src/main/client/batch_get_ops.c 0.00% 5 Missing ⚠️
src/main/conversions.c 87.87% 4 Missing ⚠️
src/main/client/sec_index.c 57.14% 3 Missing ⚠️
src/main/client/batch_apply.c 80.00% 1 Missing ⚠️
src/main/client/batch_operate.c 80.00% 1 Missing ⚠️
src/main/client/batch_write.c 83.33% 1 Missing ⚠️
src/main/client/get_cdtctx_base64.c 80.00% 1 Missing ⚠️
src/main/client/query.c 80.00% 1 Missing ⚠️
src/main/client/scan.c 80.00% 1 Missing ⚠️
src/main/scan/type.c 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #548      +/-   ##
==========================================
- Coverage   81.35%   81.33%   -0.02%     
==========================================
  Files         100      100              
  Lines       15356    15395      +39     
==========================================
+ Hits        12493    12522      +29     
- Misses       2863     2873      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DomPeliniAerospike and others added 3 commits May 10, 2024 15:30
changed pool_destroy to true for querys and scans
* [CLIENT-1837] CI/CD: Label version with git commit when building on a non-tagged commit (#605)

* Also label version when building unoptimized, with macOS debug support, or with uncommitted changes to the repo (i.e add a "dirty" label)
* Rename config.conf to config.conf.template and add config.conf to .gitignore, so creating and modifying config.conf won't cause the repo to be in a dirty state

* Auto-bump version to 15.0.1rc3.dev1 [skip ci]

* [DEVOPS-234] CI/CD: Build manylinux wheels and upload them to JFrog on every push to an arbitrary branch (#606)

* CI/CD: Add option to build and upload unoptimized wheels to JFrog for QE

* Auto-bump version to 15.0.1rc3.dev2 [skip ci]

---------

Co-authored-by: juliannguyen4 <109386615+juliannguyen4@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants