Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLIENT-2159] Fix more memory leaks #524

Draft
wants to merge 23 commits into
base: stage
Choose a base branch
from
Draft

[CLIENT-2159] Fix more memory leaks #524

wants to merge 23 commits into from

Conversation

juliannguyen4
Copy link
Collaborator

No description provided.

@juliannguyen4 juliannguyen4 changed the base branch from dev to stage September 28, 2023 14:35
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023 •
edited

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (31add98) 81.25% compared to head (1e30768) 81.21%.

Files Patch % Lines
src/main/exception.c 93.96% 12 Missing ⚠️
src/main/client/info.c 0.00% 3 Missing ⚠️
src/main/client/sec_index.c 50.00% 1 Missing ⚠️
src/main/scan/apply.c 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            stage     #524      +/-   ##
==========================================
- Coverage   81.25%   81.21%   -0.04%     
==========================================
  Files          99       99              
  Lines       14897    14797     -100     
==========================================
- Hits        12105    12018      -87     
+ Misses       2792     2779      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 changed the base branch from stage to dev October 2, 2023 21:21
@juliannguyen4 juliannguyen4 changed the base branch from dev to stage October 2, 2023 21:23
@juliannguyen4
[CLIENT-2159] Fix aerospike module leak when it is automatically free…
5eb1370 
…d by garbage collector
@juliannguyen4
precommit run
096ae5a
@juliannguyen4
Fix one leak
2b7d1c6
@juliannguyen4
Revert "precommit run"
2ec7c43 
This reverts commit fb162ed.
@juliannguyen4
Revert "[CLIENT-2159] Fix aerospike module leak when it is automatica…
1e52f6e 
…lly freed by garbage collector"

This reverts commit 4d081e2.
@juliannguyen4
re-add remove_exception()
cec6750
@juliannguyen4
fix declaration
14864ce
@juliannguyen4
Try telling GC how to traverse aerospike module
d13e485
@juliannguyen4
try to fix aerospike.exceptions leak
293c59c
@juliannguyen4
fix mem error
f71729b
@juliannguyen4
Fix import error
64f085f
@juliannguyen4
fix syntax
58b7624
@juliannguyen4
Instead of importing, use PyState_FindModule
054da52
@juliannguyen4
Add module to state when initializing
d012257
@juliannguyen4
Remove reference to exceptions in module constructor once we finish u…
fb5c9b5 
…sing them
@juliannguyen4
Fix syntax
69ef847
@juliannguyen4
Why embed interpreter in our client?
b3f543d
@juliannguyen4
WIP removing references to raise_exception_old
990973b
@juliannguyen4
fix bug, remove more refs to old method
57aced5
@juliannguyen4
revert to old c client commit
516e3e0
@juliannguyen4
Finish raise_exception_base
0055873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juliannguyen4 @codecov-commenter