Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker hub link creation for releases #1007

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

BreakBB
Copy link
Contributor

@BreakBB BreakBB commented Apr 10, 2024

What this PR does / why we need it:
Currently the link generated for the release body has the following format:

https://hub.docker.com/r/adorsys/keycloak-config-cli/tags?name=v5.12.0

However the docker images omit the v-prefix, so these links don't provide any results.

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jonasvoelcker
Copy link
Collaborator

Hi @BreakBB,

could you please rebase your PRs onto the current main so we can see whether the Github Actions work now?

Best Regards
Jonas

@jonasvoelcker
Copy link
Collaborator

Hi @BreakBB,

I managed to merge the current main into your branch and pushed it. The CI-change you did is still invalid: https://github.com/adorsys/keycloak-config-cli/actions/runs/9399408127

The workflow is not valid. .github/workflows/ci.yaml (Line: 289, Col: 17): Unexpected symbol: '('. Located at position 24 within expression: github.ref_name.replace('v', '')

Best Regards
Jonas

Signed-off-by: Jonas Voelcker <barmer@jonas-voelcker.de>
Signed-off-by: Jonas Voelcker <barmer@jonas-voelcker.de>
Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jonasvoelcker
Copy link
Collaborator

Hi @francis-pouatcha,
would you be so kind to take a look at this change, whether it might do the job or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants