This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix jQuery 1.8 deprecations #4026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -2832,11 +2832,11 @@ | |||
| if(this._get_settings().checkbox.two_state) { | |||
| if(state) { | |||
| obj.removeClass("jstree-checked").addClass("jstree-unchecked"); | |||
| if(rc) { obj.children(":checkbox").prop("checked", false); } | |||
| if(rc) { obj.children('[type="checkbox"]').prop("checked", false); } | |||
There was a problem hiding this comment.
Nit: Can you flip the quotes by using single quote inside? Our coding policy is to use double-quotes for all strings. Same goes to all other ":checkbox" replacements. Or you can even drop the inner quotes since it is optional.
There was a problem hiding this comment.
Ahh, OK. I'm used to using double quotes around attribute values and didn't realize you can leave quotes off of the selectors entirely.
|
Looks good. Merging. |
RaymondLim
added a commit
that referenced
this pull request
May 30, 2013
Fix jQuery 1.8 deprecations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #4018. It corrects the deprecations listed there.