ACNA- 1833 | Implementing external workflows #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amulyakashyap09
requested review from
shazron,
purplecabbage,
moritzraho,
arjuncooliitr,
sandeep-paliwal and
MichaelGoberling
|
Same comments as the app plugin PR, recent runs of these jobs are failing. Should have them passing before we merge. |
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 231 231
Branches 60 60
=========================================
Hits 231 231 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
purplecabbage
requested changes
Apr 18, 2023
| SLACK_MESSAGE: ${{ matrix.node-version }} | ||
| SLACK_COLOR: ${{ job.status == 'success' && 'good' || job.status == 'cancelled' && '#808080' || 'danger' }} | ||
|
|
||
| # if: github.repository == 'adobe/aio-cli-lib-app-config' |
There was a problem hiding this comment.
you should keep this line, otherwise these actions will run everyday on every fork ( and fail )
|
Also, have a look here: https://github.com/adobe/.github/tree/91ba8f2c7a4fe1178181a93b5c0186c285b43f1c/workflow-templates |
|
@amulyakashyap09 Is this PR still needed? Seems external workflows were already added with #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement reusable github workflows
Related Issue
ACNA-1833
Motivation and Context
Code Reusability
Avoiding Redundancy
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: