Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config switching support #92

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: config switching support #92

wants to merge 8 commits into from

Conversation

dylandepass
Copy link
Member

@dylandepass dylandepass commented Mar 8, 2024

Support switching between configs when multiple config matches are found.

Screenshot 2024-03-08 at 3 45 21 PM

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.75%. Comparing base (4300e2e) to head (a840345).
Report is 1 commits behind head on main.

❗ Current head a840345 differs from pull request most recent head fee7d22. Consider uploading reports for the commit fee7d22 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   96.65%   96.75%   +0.10%     
==========================================
  Files          41       43       +2     
  Lines        1195     1233      +38     
==========================================
+ Hits         1155     1193      +38     
  Misses         40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dylandepass
Copy link
Member Author

This is based on the designs from Killian but I'm think it will likely need to change. Shouldn't be too bad to move in the future.

Also wondering if we can just drop the config switcher ui now and just default to the first on in the list of matching Configs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant