feat: http error handling without retries #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basecode
approved these changes
Mar 14, 2024
actions/AuthAction.js
Outdated
| }) | ||
| .get() | ||
| .json(); | ||
| const { valid } = response; |
actions/Network.js
Outdated
Comment on lines
32
to
34
| .resolve((_) => _.setTimeout(REQUEST_TIMEOUT)) | ||
| .resolve((_) => { | ||
| return _.fetchError((error) => { |
There was a problem hiding this comment.
Generally, _ is used as a placeholder for unused parameter. However, using _ in this way creates confusion as to why a method is called on it. I would have preferred a parameter name such as request.
web-src/src/helpers/NetworkHelper.js
Outdated
Comment on lines
25
to
26
| .resolve((_) => { | ||
| return _ |
There was a problem hiding this comment.
I would have preferred a parameter name such as request.
askayastha22
requested changes
Mar 15, 2024
askayastha22
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's inside:
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: