New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reading and writing prompts using settings api #204
Conversation
# Conflicts: # data/bundledPromptTemplates.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Please add test cases for functions with signification business logic.
- Please make use of logging to EIM for signifcation CRUD handlers. Examples:
log('promptTemplate:save, {name, queryId, shared: true/false, description: true/false}');
log('promptTemplate:delete, {name, queryId, shared: true/false}');
log('prompt:generate', {adobeTarget=true/false, csv=true/false});
key: 'promptTemplatesState', | ||
get: async ({ get }) => { | ||
const bundledPromptTemplates = get(bundledPromptTemplatesState); | ||
const customPromptTemplates = await get(customPromptTemplatesState); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is await
necessary here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is required. customPromptTemplatesState
is async
🥳 |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: