Remove tox dependency. Add Python 3.10 support #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to allow for building the Linux wheels with the more recent 'manylinux2010' image instead of the 'manylinux1' image. 'manylinux1' does not support CPython 3.10 pypa/manylinux#994 List of manylinux images: https://github.com/pypa/manylinux#docker-images
|
Ditching tox is a great thing for distro packagers. Upstream suites that cater to tox and/or other isolation techniques make it really hard to test code in the context of a distribution package — which for us is what matters. |
alerque
approved these changes
Jan 17, 2022
josh-hadley
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing tox it makes it more onerous for a developer to run the tests on a multitude of Python environments locally. On the other hand, removing tox streamlines our test-config setup, and makes it easier (and faster!) to run the tests on different Python+OS configurations through the GitHub Actions CI.
The CI workflow now runs faster (9min vs. 14min) because code coverage was always on.
The Python 3.10 wheels are built in a separate step from the Python 3.7—3.9 wheels because the
manylinux1image does not support CPython 3.10.