[WIP] Fix deadlocking when sending an action in a response #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I'm just submitting this PR for feedback, I'm sure my code can use some improvement.
I believe I created a test that recreates the issue I reported in #40. I am able get the test to succeed by adding async to two fire_event calls in stream.rb. (See diff)
I appreciate any feedback. Is what I did a good idea or not? I know the mocked_server2 method I added may not be necessary, but I needed a way to send an action in the event handler.
I'm also curious about how this works in Adhearsion--how come it doesn't deadlock. So I'm going to study that code next when I have a chance.