Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add missing properties (fixes #305) #306

Merged
merged 4 commits into from
May 17, 2024
Merged

Fix: Add missing properties (fixes #305) #306

merged 4 commits into from
May 17, 2024

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented May 13, 2024 •
edited

Fixes #305

Fix

  • Adds _isMobileTextBelowImage and _isStackedOnMobile where missing in schemas and documentation (see issue description)
  • Updates some property descriptions to indicate that they only apply when the Hot Graphic is configured to render as a Narrative on mobile

@swashbuck swashbuck self-assigned this May 13, 2024
@swashbuck swashbuck added the bug label May 13, 2024
guywillis
guywillis approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@swashbuck swashbuck marked this pull request as ready for review May 15, 2024 18:15
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@swashbuck swashbuck merged commit d966174 into master May 17, 2024
@swashbuck swashbuck deleted the issue/305 branch May 17, 2024 15:50
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@guywillis guywillis guywillis approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@swashbuck swashbuck

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing properties
4 participants
@swashbuck @oliverfoster @guywillis @cahirodoherty-learningpool