Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Allow static tooltips, improved render and styling #529

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Apr 30, 2024

fixes #528

Update

  • Returned tooltip model from the tooltips.register function, allowing live updates to the tooltip text from external data
  • Improved render performance by more tightly controlling when a tooltip is rendered and aligning the render with the browser animation frames
  • Allowed css variables --adapt-tooltip-distance: 1rem; and -adapt-tooltip-arrow: true; to be captured from the computed styling of the tooltip and to have impact in the rendering process, facilitating LESS styling of the tooltip distance from target and its arrow presentation
  • Ensured that css variables are used in style calculations at runtime rather than compile time

New

  • Add _isStatic, _distance and _hasArrow properties to tooltip registry, allowing tooltips do vary in their presentation, distance from target and arrow existence
  • No entry animation on static tooltip rerender
  • No accessibility announce of static tooltips

Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, I've raised an issue when testing this with issue/303. I'm not sure if this is specific to Hotgraphic or impacts this PR.

Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safari issue resolved thanks 👍

@oliverfoster oliverfoster merged commit 0b3b098 into master Jun 5, 2024
@oliverfoster oliverfoster deleted the issue/528 branch June 5, 2024 13:15
github-actions bot pushed a commit that referenced this pull request Jun 5, 2024
# [6.49.0](v6.48.0...v6.49.0) (2024-06-05)

### Update

* Allow static tooltips, improved render and styling (#529) ([0b3b098](0b3b098)), closes [#529](#529)
@oliverfoster
Copy link
Member Author

🎉 This PR is included in version 6.49.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@oliverfoster oliverfoster added released enhancement New feature or request and removed bug Something isn't working labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
Status: Recently Released
Development

Successfully merging this pull request may close these issues.

Allow statically placed tooltips
4 participants