ensure a unique error message for each USBError #9240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may help with diagnosing adafruit#9226: it will tell us *which* site is unexpectedly failing after a first timed out transfer (which correctly raises USBTimeoutError)
|
Ya, generally at this point you need internal debugging to let you know what the issue is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may help with diagnosing #9226: it will tell us which site is unexpectedly failing after a first timed out transfer (which correctly raises USBTimeoutError)
This is probably not worth merging as is, as the NULL cases look like "this isn't supposed to happen" cases. It's just for diagnostic purposes, if someone wants to grab the artifacts.