Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add I2CTarget documentation, fix problem with I2C restart requests [#9232] #9236

Merged
merged 3 commits into from May 13, 2024

Conversation

ajmirsky
Copy link

@ajmirsky ajmirsky commented May 10, 2024

is_restart on an I2CTargetRequest wasn't getting set properly because the incorrect register mask was being used.

also, added documentation with two different examples of how to create an I2CTarget

Closes: #9232, #9215

…Target()` class

Signed-off-by: Andrew Mirsky <andrew@mirsky.net>
issue #: adafruit#9232

Signed-off-by: Andrew Mirsky <andrew@mirsky.net>
Signed-off-by: Andrew Mirsky <andrew@mirsky.net>
@jepler
Copy link
Member

jepler commented May 11, 2024

[I updated the initial comment so that it links to the related issue.]

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@tannewt tannewt merged commit b340b73 into adafruit:main May 13, 2024
149 checks passed
@ajmirsky
Copy link
Author

ajmirsky commented May 15, 2024

Updated the description as this pull request should also close issue #9215.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I2CTarget doesn't properly set is_restarted on requests
3 participants